-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mieubrisse/fix dockerfiles #529
base: master
Are you sure you want to change the base?
Changes from 4 commits
a32bce3
c851386
647c1c7
f03b4e0
4dd7721
ec9a0e0
4f24184
70be1a8
0a1e44e
6d6a3ff
3c6c700
8189ff0
3551bcd
76355c0
80f388f
6615da2
47f66b5
f61f5f5
4b04294
89bffda
638ed6f
ab17ca8
8dc2b4a
b0cd5e4
1d2c3b5
b4f7422
a74606f
e20142a
44581e5
531c603
e428364
54648cb
dc8bc61
3093524
02f9d82
4e12d8a
8b8fb5d
ed0ab09
afb4720
62c6914
90edc54
95ab14b
96f4404
38dd340
ccd3cd6
4ca21d7
11cb217
7eb3756
2df0952
43aa10f
0960483
e0c2ae2
9de59bb
c92be22
49c9194
57d2eb8
ef41710
99d45d3
c3f2934
a7dfb09
c25fb84
80d38f6
b6a8d0f
a352938
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
image: gitpod/workspace-postgres | ||
tasks: | ||
# NOTE: As of 2021-1012, the contract helper DB seems to use the indexer DB so this likely won't work anymore | ||
- init: yarn && ./scripts/create_dev_dbs.sh | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like this PR deletes this file, but still references it here in the |
||
github: | ||
prebuilds: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,8 @@ | ||
FROM nearprotocol/bridge as bridge | ||
# TODO pin Node version so the image isn't constantly updating under us? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think pinning it to the major version is fine, especially since we intentionally stick to LTS versions (not bleeding edge) where breaking changes are highly unlikely... |
||
FROM node:12 | ||
WORKDIR /usr/app | ||
COPY ./package.json . | ||
COPY ./yarn.lock . | ||
RUN yarn | ||
COPY . . | ||
RUN grep -v ACCOUNT_CREATOR_KEY .env.sample | grep -v NODE_URL | grep -v INDEXER_DB_CONNECTION > .env | ||
COPY --from=bridge /root/.near/localnet/node0/validator_key.json . | ||
RUN ACCOUNT_CREATOR_KEY=$(cat validator_key.json | tr -d " \t\n\r") && echo "ACCOUNT_CREATOR_KEY=$ACCOUNT_CREATOR_KEY" >> .env | ||
CMD ["sh", "-c", "sleep 10 && yarn migrate && yarn start"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||
CMD ["sh", "-c", "yarn start-without-env"] |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't true actually -- we use the indexer DB for some things, like finding all accounts for a given public key, or finding recent transactions, but the accounts and recovery methods are entirely a wallet construction, not part of the indexer/on-chain data, and still provided by the local accounts SQL DB instance.