Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Transaction Details Page #109

Merged
merged 2 commits into from Oct 21, 2019
Merged

Implemented Transaction Details Page #109

merged 2 commits into from Oct 21, 2019

Conversation

frol
Copy link
Collaborator

@frol frol commented Oct 15, 2019 •
edited

Resolves #91

Notes:

  1. Transaction fees are not currently exposed via RPC, so we cannot show them yet. Better tx RPC API nearcore#1299
  2. Action result and logs are not implemented yet, this is the only item left to be implemented.
  3. Mobile is ok, but we should definitely get back to it one day to review mobile readiness (including performance and network traffic size optimization) Improve mobile experience #111
  4. Tests are coming
  5. Links to the transaction details page from the dashboard, list of transactions, block details, account details pages work fine (in fact, those pages reuse the same component, so it was just a change in a single place)
  6. Render.com deployment won't work for this PR as it introduces a change on the proxy-backend.

Here is an example of a direct link to a transaction: https://near-explorer-frontend-pr-109.onrender.com/transactions/3dYfigPo3FGTb9rN2KhyXTXWrPsYaRDK69FTHW9So9Ff

image

@render
Copy link

render bot commented Oct 15, 2019 •
edited

Your Render PR Server at https://near-explorer-frontend-pr-109.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-bmimigfndio0g3tcg1bg.

@frol frol force-pushed the feature/transaction-details-page branch from 9f10144 to b1cb153 Compare October 18, 2019 21:56
@frol frol changed the title WIP: Implemented Transaction Details Page Implemented Transaction Details Page Oct 18, 2019
@frol frol requested review from deacix and kcole16 October 18, 2019 22:00
@frol frol merged commit 36a6ba6 into master Oct 21, 2019
@frol frol deleted the feature/transaction-details-page branch October 27, 2019 07:37
deacix added a commit that referenced this pull request Oct 31, 2019
@deacix
Merge commit 'f6e22c0b41ec1852b04b5e8165d501a2873049f2' into feature/…
b2cd0f0 
…search-box-99

* commit 'f6e22c0b41ec1852b04b5e8165d501a2873049f2':
  Implemented multinet support (resolves #110)
  Use a non-released version of nearlib with chunks API support (resolves #115)
  Resolved the compatibility issues with nearcore 0.4 (resolves #115)
  Fixed the double-reversed ordering issue on the Transactions list page
  Implemented Transaction Details Page (#109)
  Fixed actions ordering
  Feature/e2e (resolves #89)

# Conflicts:
#	frontend/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcole16 kcole16 kcole16 approved these changes

@deacix deacix Awaiting requested review from deacix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction Detail Page
2 participants
@frol @kcole16