feat: Add meta transaction support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/meta-transactions
branch
from
b578731
to
411c942
Compare
morgsmccauley
force-pushed
the
feat/meta-transactions
branch
from
411c942
to
b9d4e2b
Compare
morgsmccauley
commented
Feb 21, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "near-lake-framework", | |||
| "version": "1.0.6", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Bumped the major version but I'm not actually sure this considered a breaking change? 🤔
There was a problem hiding this comment.
Unfortunately, it is a breaking change. Since the previous version is not going to get the DelegatedAction action when it is in the JSON
khorolets
approved these changes
Feb 21, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "near-lake-framework", | |||
| "version": "1.0.6", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Unfortunately, it is a breaking change. Since the previous version is not going to get the DelegatedAction action when it is in the JSON
morgsmccauley
force-pushed
the
feat/meta-transactions
branch
2 times, most recently
from
b97a14f
to
f8f74c8
Compare
morgsmccauley
force-pushed
the
feat/meta-transactions
branch
from
f8f74c8
to
cdaa621
Compare
|
@khorolets FYI I've added a GitHub action to run tests, we might want to make this a required check in the repo settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type support for meta transaction/delegate actions. Additionally it bootstraps a test suite to ensure that
fetchStreamerMessage()serialises meta transactions correctly.