test: Meta transaction deserialization #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
commented
Feb 21, 2023
morgsmccauley
commented
Feb 21, 2023
src/s3_fetchers.rs
Outdated
| }; | ||
|
|
||
| #[async_trait] | ||
| pub trait GetObject { |
There was a problem hiding this comment.
Implementation taken from https://docs.aws.amazon.com/sdk-for-rust/latest/dg/testing.html
morgsmccauley
force-pushed
the
feat/meta-transaction
branch
2 times, most recently
from
3c41f86
to
2c69bac
Compare
morgsmccauley
force-pushed
the
test/meta-transactions
branch
from
83629e3
to
24a3cce
Compare
khorolets
reviewed
Feb 22, 2023
khorolets
force-pushed
the
test/meta-transactions
branch
from
4ded912
to
d236ec9
Compare
morgsmccauley
force-pushed
the
test/meta-transactions
branch
from
54e5fab
to
be3aea7
Compare
morgsmccauley
commented
Feb 23, 2023
| async-stream = "0.3.3" | ||
|
|
||
| [dev-dependencies] | ||
| aws-smithy-http = "0.53.0" |
There was a problem hiding this comment.
Needed for constructing an S3 response body via SdkBody
morgsmccauley
commented
Feb 23, 2023
morgsmccauley
commented
Feb 23, 2023
|
@khorolets this is ready for review now. Thanks a lot for you help! |
khorolets
requested changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for
s3_fetchers, with the goal of testing the deserialization of meta transactions. It does this by creating a newtraitto abstract awayaws_sdk_s3::Clientproviding the ability to inject fake implementations which have mock S3 responses.I've also added another step to the existing github action which will run the tests.