Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerate keys/elements and pagination #337

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Enumerate keys/elements and pagination #337

merged 5 commits into from
Feb 2, 2023

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Feb 1, 2023

Address #302

@ailisp ailisp requested a review from volovyks as a code owner February 1, 2023 07:19
@ailisp
Copy link
Member Author

ailisp commented Feb 1, 2023 •
edited
Loading

weird, the build and nft standard tests are passing locally but fail on ci.

Update: the problem is turbo incorrectly cache the near-contract-standards build locally. I'll create an issue

volovyks
volovyks approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ailisp !

@ailisp ailisp merged commit 8a26658 into develop Feb 2, 2023
@ailisp ailisp deleted the enum-keys branch February 2, 2023 01:44
@ailisp ailisp mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ailisp @volovyks