Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor info_extractor to accumulate compilation errors #1097

Merged
merged 8 commits into from Oct 19, 2023
Merged

Refactor info_extractor to accumulate compilation errors #1097

merged 8 commits into from Oct 19, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Oct 19, 2023 •
edited

Closes #1006

@iho iho marked this pull request as ready for review October 19, 2023 06:56
frol
frol approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement to the developer experience!

@frol frol merged commit 6851188 into near:master Oct 19, 2023
13 of 14 checks passed
@frol frol mentioned this pull request Oct 19, 2023
Closed
@frol frol mentioned this pull request Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro agostbiro is a code owner

@uint uint Awaiting requested review from uint uint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor info_extractor to accumulate compilation errors
3 participants
@iho @frol @jaswinder6991