Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add #[borsh(crate =...)] mentions in readme (#1129) #1132

Merged
merged 1 commit into from Jan 16, 2024
Merged

doc: add #[borsh(crate =...)] mentions in readme (#1129) #1132

merged 1 commit into from Jan 16, 2024

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Jan 16, 2024 •
edited

this may help in cases like #1129

@dj8yfo dj8yfo marked this pull request as ready for review January 16, 2024 17:45
@frol
Copy link
Collaborator

frol commented Jan 16, 2024

@dj8yfo I wonder if it would be nicer if #[near_bindgen] would add Borsh derives automatically in the first place. Since bindgen expects the state struct to be serialized to borsh, I feel it is not helpful to leave it up to the users to write derives manually. What do you think?

@frol frol merged commit fefb664 into near:master Jan 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol Awaiting requested review from frol frol is a code owner

@agostbiro agostbiro Awaiting requested review from agostbiro agostbiro is a code owner

@uint uint Awaiting requested review from uint uint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dj8yfo @frol