Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated store::UnorderedMap and store::UnorderedSet due to not meeting the original requirements (iteration over a collection of more than 2k elements runs out of gas) #1139

Merged
merged 14 commits into from Feb 12, 2024
Merged

fix: deprecated store::UnorderedMap and store::UnorderedSet due to not meeting the original requirements (iteration over a collection of more than 2k elements runs out of gas) #1139

merged 14 commits into from Feb 12, 2024

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Feb 8, 2024 •
edited

  • deprecated store::UnorderedMap due to its fragmentation property
  • deprecated store::UnorderedSet due to its fragmentation property

@ruseinov ruseinov marked this pull request as ready for review February 8, 2024 22:47
frol
frol requested changes Feb 8, 2024
View reviewed changes
near-sdk/src/store/frangible_map/mod.rs Outdated Show resolved Hide resolved
near-sdk/src/store/unordered_set/mod.rs Outdated Show resolved Hide resolved
@ruseinov ruseinov requested a review from frol February 9, 2024 10:48
@ruseinov
Copy link
Contributor Author

ruseinov commented Feb 9, 2024

@frol this will need a test re-run due to a flaky test.

@frol
Copy link
Collaborator

frol commented Feb 10, 2024

Renaming won't help us to introduce UnorderedMap name back (see my #1134 (comment)). So I don't think renaming is the right move here.

@ruseinov
Copy link
Contributor Author

Renaming won't help us to introduce UnorderedMap name back (see my #1134 (comment)). So I don't think renaming is the right move here.

Right, let's deprecate them then.

frol
frol requested changes Feb 11, 2024
View reviewed changes
examples/versioned/src/lib.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ruseinov
Copy link
Contributor Author

@frol all fixed.

@ruseinov ruseinov requested a review from frol February 12, 2024 15:17
@frol frol changed the title [Fix] store::UnorderedMap -> store::FrangibleUnorderedMap. fix: deprecated store::UnorderedMap and store::UnorderedSet due to not meeting the original requirements (iteration over a collection of more than 2k elements runs out of gas) Feb 12, 2024
@frol frol merged commit 61b9590 into near:master Feb 12, 2024
13 checks passed
@frol frol mentioned this pull request Feb 12, 2024
Merged
@frol frol mentioned this pull request Feb 19, 2024
Closed
encody added a commit to near/multichain-gas-station-contract that referenced this pull request Apr 4, 2024
@encody
fix: switch back to near_sdk::collections due to performance issue ne…
7590d6e 
…ar/near-sdk-rs#1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro agostbiro is a code owner

@uint uint Awaiting requested review from uint uint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruseinov @frol