Introduce near macro #1147
Merged
Introduce near macro #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyProgrammist
force-pushed
the
boilerplate
branch
from
56ff344
to
df8f9e5
Compare
frol
previously approved these changes
Mar 14, 2024
Comment on lines
18
to
20
| #[derive(BorshSerialize, BorshDeserialize, NearSchema)] | ||
| #[inside_nearsdk] | ||
| #[abi(borsh)] |
There was a problem hiding this comment.
- Do we need to manually derive Borsh/Schema? I would expect that
#[near]would also work here - Instead of
#[inside_nearsdk], can we add a parameter, so you can just write#[near(crate="crate")]? This way we will also allow re-embedding near_sdk if necessary
|
Overall, this looks great to me! I have only one question, but if it would take longer than a day to implement, let's ignore it since everything else is already implemented and looks great! |
Decided to skip it with Vlad for now. Since crate is a keyword and darling can't handle that. It requires a manual attribute parsing |
frol
previously approved these changes
Mar 15, 2024
frol
reviewed
Mar 15, 2024
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
frol
previously approved these changes
Mar 15, 2024
frol
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1142