feat: nep330 build info field of contract metadata #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_CODE_SNAPSHOT`
4 tasks
dj8yfo
force-pushed
the
add_contract_metadata
branch
from
bbba413
to
bf81221
Compare
dj8yfo
force-pushed
the
add_contract_metadata
branch
from
d7c9d0b
to
b3bd35c
Compare
frol
requested changes
Jun 5, 2024
| FieldError::UnsetOrEmptyBuildCommand | ||
| ); | ||
| let build_command = | ||
| build_command.split_whitespace().map(|st| st.to_string()).collect::<Vec<_>>(); |
There was a problem hiding this comment.
Ouch, split_whitespace is not something we want to take chances with. Let's find a lossless way of passing BUILD_COMMAND. JSON array of strings? So, basically, serde_json::from_str::<Vec<String>>(build_command)
There was a problem hiding this comment.
yeap, this does look like a great alternative to me)
frol
reviewed
Jun 5, 2024
| } | ||
| env_field!( | ||
| self.link, | ||
| std::env::var("CARGO_NEAR_REPO_LINK_HINT").or(std::env::var("CARGO_PKG_REPOSITORY")) |
There was a problem hiding this comment.
Instead of CARGO_NEAR_* prefix, I would use NEP330_ prefix with the matching names of the fields:
NEP330_VERSION
NEP330_LINK
NEP330_BUILD_INFO_BUILD_ENVIRONMENT
...
This way we won't depend on cargo-near implementation detail. In this case, the naming should be dictated by near-sdk-rs.
dj8yfo
added a commit
to dj8yfo/near-sdk-rs
that referenced
this pull request
Jun 6, 2024
dj8yfo
force-pushed
the
add_contract_metadata
branch
from
a34e7ef
to
9ff44ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.