ci: fix new lints, introduced in 1.78 #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 19:23
ci: fix 1.78 lints
dj8yfo
commented
May 7, 2024
| @@ -16,6 +16,7 @@ pub struct DeFi { | |||
| } | |||
|
|
|||
| // Have to repeat the same trait for our own implementation. | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
value_please on line 57 is called on DeFiExt , so the lint is correct here
|
Looks perfect. |
frol
approved these changes
May 21, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this new lint was silenced , it introduces 30+ locations to fix: https://rust-lang.github.io/rust-clippy/master/index.html#/multiple_bound_locations ; it has no automatic fix yet with
cargo clippy --fix