fix: remove payable check for non-mutable functions

[austinabell]

Opinionated change, probably shouldn't come in, opening for discussion. It was a foot gun for what I was just doing, but it doesn't seem super clean to just remove.

Pros:

• Removes foot gun of trying to call a method without parameters as a view call and failing

Cons:

• Silently removes non-payable check to anyone using this method and modifying state manually

Neutral:

• Moves in direction of non-payable methods by default. Unclear if developers expect this or benefit from the security of this by default (probably requires developer input cc @AustinBaggio). Is a pattern in Ethereum by default, but doesn't fit cleanly into our model because attached_deposit fails by default in view context. (I will follow up to ask why this is the case and not just defaulting to 0 https://near.zulipchat.com/#narrow/stream/295306-pagoda.2Fcontract-runtime/topic/attached_deposit.20view.20error/near/277355733)

[MaksymZavershynskyi]

Is this a backwards-compatible change from the perspective of API or behavior?

[austinabell]

Is this a backwards-compatible change from the perspective of API or behavior?

Are you referring to the change in this draft or the proposed protocol change?

The draft PR change is backwards compatible from the API surface, but just would remove the payable check by default. Not going to open this PR up, was created more for discussion.

[austinabell]

Also, I have a terrible memory, because there was already an issue for this: #718

[austinabell]

Closing this because the logic in nearcore was changed in near/nearcore#8433

The better solution now is to just have the non-payable check on all methods, and only remove if the attribute payable is applied.