chore: bump contract builder to version 1.61 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
approved these changes
May 19, 2022
itegulov
approved these changes
May 20, 2022
Nope, didn't notice it had been released. Will update to that |
austinabell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.60 is needed to be able to build the nearcore crates used for unit testing after #820 as can be seen from this failed buildkite https://buildkite.com/nearprotocol/near-sdk-rs/builds/4076#090f7030-7abe-48bf-80a0-95fbce8f323f
This adds more value to https://github.com/near/near-ops/issues/839 since using
latestand bumping people's images based on this for updates like this isn't a good pattern. cc @anshal-savlaAlso noting that changes like this would break old CI runs on this repo since the toolchain is different and would produce different binaries -- there should be a way to specify the Rust toolchain version on the image tag