fix(store::TreeMap): remove of the entry API now correctly updates the tree root when changed #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tree root when changed
austinabell
requested review from
ChaoticTempest and
itegulov
as code owners
|
Opinionated if this change is also backported to the There is no bug in that collection because the root is updated whenever that function is called, but an argument could be made to make this change for the off-chance changes are made to it that don't uphold this assumption. |
|
@itegulov @ChaoticTempest Kindling pinging you as code owners to review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was within the
removemethod of the entry API, which removed the element but did not update the root based on what was returned from do_remove.This was a weird side effect to have to uphold after calling do_remove, so this seems like the correct refactor rather than just updating the root within that function.
Closes #993