refactor: streamline running on localnet #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://near-wallet-pr-861.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bt79o52pp1jl6vv04450. |
|
Your Render PR Server URL is https://betanet-wallet-pr-861.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bt79o6app1jl6vv044kg. |
mattlockyer
previously requested changes
Sep 1, 2020
The main goal: if you're already running a local NEAR network, make it
as easy as possible to run a local contract-helper & Wallet on that
network.
There is no need to gitignore `.env.local` since it stores no sensitive
info. Including it makes it much easier to run on a local network with
one command:
NODE_ENV=local yarn start
Also, note that when running a local network with nearup or
rainbow-bridge-cli, the only validator account is named `node0`. Using
this as the account creator in contract-helper is the simplest way to
get started (see near/near-contract-helper#221),
which means the account suffix here needs to match.
I think this is a confusing suffix and would much prefer `localnet`, but
I don't know if that's worth doing now. Ideally such a change would flow
out from `nearup`, rather than being part of the setup in
`near-contract-helper` or here.
|
Your Render PR Server URL is https://near-mainnet-staging-wallet-pr-861.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bu2ccdf93em9ftsqji40. |
|
@mattlockyer good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal: if you're already running a local NEAR network, make it as easy as possible to run a local contract-helper & Wallet on that network.
Someone in such a situation will very likely be running a different app using Parcel on port 1234, and will need to sign into Wallet using a different port. This switches the local Wallet port to 4000.
There is no need to gitignore
.env.localsince it stores no sensitive info. Including it makes it much easier to run on a local network with one command:Finally, note that when running a local network with nearup or rainbow-bridge-cli, the only validator account is named
node0. Using this as the account creator in contract-helper is the simplest way to get started (see near/near-contract-helper#221), which means the account suffix here needs to match.I think this is a confusing suffix and would much prefer
localnet, but I don't know if that's worth doing now. Ideally such a change would flow out fromnearup, rather than being part of the setup innear-contract-helperor here.