feat-issue-123: add rpc url env to replace default rpc url #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Sep 8, 2023
packages/js/src/utils.ts
Outdated
| } else if (network === 'testnet' && process.env.NEAR_CLI_TESTNET_RPC_SERVER_URL) { | ||
| rpcAddr = process.env.NEAR_CLI_TESTNET_RPC_SERVER_URL; | ||
| } | ||
| console.log(); |
ailisp
reviewed
Sep 8, 2023
| @@ -217,7 +216,7 @@ export abstract class AccountManager implements NearAccountManager { | |||
| } | |||
|
|
|||
| protected get connection(): nearAPI.Connection { | |||
| return new nearAPI.Connection(this.networkId, this.provider, this.signer); | |||
| return new nearAPI.Connection(this.networkId, this.provider, this.signer, `jsvm.${this.networkId}`); | |||
There was a problem hiding this comment.
I used the incorrect near api js version cached on my mechine, so I add a new param to run test on my local mechine, I will changed it
|
CI fails need to be fixed. I recently tried main branch can pass: #218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use env varibles to set rpc url
#123