Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storing credentials #258

Merged
merged 2 commits into from Jan 10, 2023
Merged

fix: storing credentials #258

merged 2 commits into from Jan 10, 2023

Conversation

ChaoticTempest
Copy link
Member

Notice this minor issue where storing the credentials doesn't store the parent id for a subaccount (i.e. sub.parent would get stored as sub.json). This was due to Path::set_extension("json") setting parent into json which I didn't notice earlier till now.

miraclx
miraclx approved these changes Jan 9, 2023
View reviewed changes
workspaces/src/types/account.rs Show resolved Hide resolved
workspaces/src/rpc/tool.rs Show resolved Hide resolved
@ChaoticTempest ChaoticTempest merged commit 9014f3a into main Jan 10, 2023
@ChaoticTempest ChaoticTempest deleted the fix/store-credentials branch January 10, 2023 00:57
@frol frol mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx approved these changes

@itegulov itegulov Awaiting requested review from itegulov

@DavidM-D DavidM-D Awaiting requested review from DavidM-D

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChaoticTempest @miraclx