chore: cleanup internals #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Oct 22, 2023
workspaces/src/rpc/client.rs
Outdated
| actions.clone(), | ||
| block_hash, | ||
| ), | ||
| signed_transaction(signer, actions.clone(), nonce, block_hash, receiver_id), |
There was a problem hiding this comment.
I prefer constructor method (from_actions or maybe other name) on SignedTransaction over a standalone function as it is harder to discover the function. What is exactly the motivation behind this change?
There was a problem hiding this comment.
The function is a reimplementation of from_actions without requiring Signer trait as an argument. The hint I took here is that we can condense that implementation and remove the reliance on the trait.
I could name it better.
workspaces/src/types/mod.rs
Outdated
Comment on lines
542
to
545
| SignedTransaction::new( | ||
| signer.secret_key.0.sign(tx.get_hash_and_size().0.as_ref()), | ||
| tx, | ||
| ) |
There was a problem hiding this comment.
you shouldn't need to call into SignedTransaction::new. A tx.sign(&signer) is simpler
frol
approved these changes
Nov 27, 2023
Merged
frol
added a commit
that referenced
this pull request
Jan 25, 2024
## 🤖 New release * `near-workspaces`: 0.9.0 -> 0.10.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.10.0](near-workspaces-v0.9.0...near-workspaces-v0.10.0) - 2024-01-25 ### Other - Impl Clone on result Value ([#345](#345)) - Upgraded NEAR crates to 0.20.0 release ([#346](#346)) - dependecy bumps ([#338](#338)) - cleanup internals ([#329](#329)) - use stable sandbox by default ([#335](#335)) - [**breaking**] Remove `interop_sdk` feature from defaults ([#339](#339)) - fix typos ([#340](#340)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: Vlad <304265+frol@users.noreply.github.com> Co-authored-by: Vlad <304265+frol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also resolving #153