feat: always display uncertain estimation warnings (#7690)

resolves #7004, see that issue for reasoning behind the change
near · Sep 26, 2022 · 1386a41 · 1386a41
1 parent 2b5dcaa
commit 1386a41
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/runtime/runtime-params-estimator/estimator-warehouse/src/check.rs b/runtime/runtime-params-estimator/estimator-warehouse/src/check.rs
@@ -170,9 +170,7 @@ fn estimation_uncertain_changes(
                 add_warning(&mut warnings, name.clone(), "None".to_owned(), uncertain_after)
             }
             (Some(uncertain_before), Some(uncertain_after)) => {
-                if !uncertain_before.eq(&uncertain_after) {
-                    add_warning(&mut warnings, name.clone(), uncertain_before, uncertain_after);
-                }
+                add_warning(&mut warnings, name.clone(), uncertain_before, uncertain_after);
             }
         }
     }

diff --git a/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-2.snap b/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-2.snap
@@ -11,7 +11,7 @@ expression: report.to_string()
 LogBase                                         5.00 Ggas ➜        6.00 Ggas (+20.00%)
 LogByte                                         1.01 Ggas ➜        7.00 Ggas (+594.44%)
 ```
-### Gas estimator uncertain changes: 2
+### Gas estimator uncertain estimations: 2
 ```
 UncertainTest                                               HIGH-VARIANCE ➜ None                            
 UncertainTest2                                                       None ➜ BLOCK-MEASUREMENT-OVERHEAD      

diff --git a/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-3.snap b/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-3.snap
@@ -10,4 +10,5 @@ expression: report.to_string()
 ```
 LogBase                                         5.00 Ggas ➜        6.00 Ggas (+20.00%)
 ```
-### Gas estimator uncertain changes: 0
+### Gas estimator uncertain estimations: 0
+
diff --git a/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-4.snap b/...estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command-4.snap
@@ -11,5 +11,5 @@ expression: report.to_string()
 AltBn128MultiExp                                    0 gas ➜           10 gas (+inf%)
 LogByte                                        15.00 Mgas ➜       20.00 Mgas (+33.33%)
 ```
-### Gas estimator uncertain changes: 0
+### Gas estimator uncertain estimations: 0
 
diff --git a/...r/estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command.snap b/...r/estimator-warehouse/src/snapshots/estimator_warehouse__check__tests__check_command.snap
@@ -10,7 +10,7 @@ expression: report.to_string()
 ```
 LogBase                                         4.00 Ggas ➜        5.00 Ggas (+25.00%)
 ```
-### Gas estimator uncertain changes: 1
+### Gas estimator uncertain estimations: 1
 ```
 UncertainTest                                               NEGATIVE-COST ➜ HIGH-VARIANCE                   
 ```

diff --git a/runtime/runtime-params-estimator/estimator-warehouse/src/zulip.rs b/runtime/runtime-params-estimator/estimator-warehouse/src/zulip.rs
@@ -105,7 +105,7 @@ impl std::fmt::Display for ZulipReport {
             }
             writeln!(f, "```")?;
         }
-        writeln!(f, "### Gas estimator uncertain changes: {}", self.changes_uncertain.len())?;
+        writeln!(f, "### Gas estimator uncertain estimations: {}", self.changes_uncertain.len())?;
         if self.changes_uncertain.len() > 0 {
             writeln!(f, "```")?;
             for change in &self.changes_uncertain {