Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test chunk validator rewards for stateless validation #11371

Open
tayfunelmas opened this issue May 21, 2024 · 1 comment
Open

Test chunk validator rewards for stateless validation #11371

tayfunelmas opened this issue May 21, 2024 · 1 comment
Assignees
Labels
A-stateless-validation Area: stateless validation

Comments

@tayfunelmas
Copy link
Contributor

Task is to make sure validator rewards are working as intended in mocknet.

Relevant PR: https://github.com/near/nearcore/pull/11121/files

@tayfunelmas tayfunelmas added the A-stateless-validation Area: stateless validation label May 21, 2024
@tayfunelmas tayfunelmas self-assigned this May 21, 2024
@tayfunelmas
Copy link
Contributor Author

RE rewards calculation: the problem with reward calculation not working is due to inflation rate set to 0 in genesis for mocknet. similar to the protocol_reward_rate problem, that the code is picking it from genesis config instead of hard-coded value or 1/20 (mainnet uses hard-coded but mocknet using genesis because protocol version starts from the genesis version):

if use_hardcoded_value { Rational32::new_raw(1, 20) } else { self.max_inflation_rate };

github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
… max inflation rate in output genesis file (#11374)

This will likely be used in the forknet setup to set specific non-zero
values for max-inflation-rate and gas-limit, so adding them to the
command proactively. The mocknet/mirror toolset uses the `amend-genesis`
command to initialize the genesis for the network to start with. There
will be follow-up changes to add these extra params to the
`amend-genesis` invocation from the mocknet setup code.

Related issue: #11371
marcelo-gonzalez pushed a commit to marcelo-gonzalez/nearcore that referenced this issue May 23, 2024
… max inflation rate in output genesis file (near#11374)

This will likely be used in the forknet setup to set specific non-zero
values for max-inflation-rate and gas-limit, so adding them to the
command proactively. The mocknet/mirror toolset uses the `amend-genesis`
command to initialize the genesis for the network to start with. There
will be follow-up changes to add these extra params to the
`amend-genesis` invocation from the mocknet setup code.

Related issue: near#11371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

No branches or pull requests

1 participant