Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit error message when receiving delayed witness part #11545

Open
1 task done
pugachAG opened this issue Jun 11, 2024 · 0 comments
Open
1 task done

Don't emit error message when receiving delayed witness part #11545

pugachAG opened this issue Jun 11, 2024 · 0 comments
Assignees
@pugachAG

Comments

@pugachAG
Copy link
Contributor

pugachAG commented Jun 11, 2024 •
edited
Loading

@telezhnaya reported seeing a many instances of the following errors in the logs:

ERROR client: Failed to handle PartialEncodedStateWitnessForwardMessage err=InvalidPartialChunkStateWitness("Height created of 119028150 in PartialEncodedStateWitness not greater than final head height 119028150")

This could happen because of network delays, so reporting this as an error is too aggressive. It is better to report it as info or debug and emit a metric instead.

Tasks
Beta Give feedback
  1. fix: fix log spam from partial witness validation #11556
@pugachAG pugachAG self-assigned this Jun 11, 2024
@pugachAG pugachAG mentioned this issue Jun 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
@pugachAG
fix: fix log spam from partial witness validation (#11556)
70e7abc 
This PR updates `validate_partial_encoded_state_witness` to not return
`Err` when partial witness could be potentially valid at some point.
Instead we write a debug log for now and I will emit metrics as part of
a separate PR.

For more context see #11545.
telezhnaya pushed a commit that referenced this issue Jun 13, 2024
@pugachAG @telezhnaya
fix: fix log spam from partial witness validation (#11556)
96d8b99 
This PR updates `validate_partial_encoded_state_witness` to not return
`Err` when partial witness could be potentially valid at some point.
Instead we write a debug log for now and I will emit metrics as part of
a separate PR.

For more context see #11545.
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pugachAG pugachAG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pugachAG