Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly failure: sanity/gc_sync_after_sync.py times out #2540

Closed
SkidanovAlex opened this issue Apr 28, 2020 · 1 comment · Fixed by #2571 or #2578
Closed

Nightly failure: sanity/gc_sync_after_sync.py times out #2540

SkidanovAlex opened this issue Apr 28, 2020 · 1 comment · Fixed by #2571 or #2578
Assignees
@Kouprin
Labels
A-chain Area: Chain, client & related

Comments

@SkidanovAlex
Copy link
Collaborator

Times out every time. Both with and without swap_nodes passed.

Example runs:

http://nightly.neartest.com/run/2cef4105736ab969470df2751e78fd3f0fc0a81d_200428_102644
http://nightly.neartest.com/run/f625606891dec008a572ca61ec37da500c2a95cd_200428_135923
@SkidanovAlex SkidanovAlex added A-chain Area: Chain, client & related nightly labels Apr 28, 2020
@SkidanovAlex SkidanovAlex changed the title Nightly failure: sanity/gc_sync_after_sync.py Nightly failure: sanity/gc_sync_after_sync.py times out Apr 28, 2020
@bowenwang1996 bowenwang1996 mentioned this issue Apr 29, 2020
Merged
@SkidanovAlex SkidanovAlex reopened this Apr 29, 2020
@SkidanovAlex
Copy link
Collaborator Author

Reopening, swap_nodes still times out

http://nightly.neartest.com/run/650ac70cfb3474fab3658057804aee5a22be78e1_200429_141007

@bowenwang1996 bowenwang1996 mentioned this issue Apr 30, 2020
Merged
nearprotocol-bulldozer bot pushed a commit that referenced this issue Apr 30, 2020
@bowenwang1996
fix(pytest): fix gc_sync_after_sync (#2578)
17943ad 
The previous fix for `gc_sync_after_sync.py` fails when `swap` is enabled because of the asymmetry in stake distribution and if the nodes are swapped, blocks cannot be produced. Fixes #2540 

Test plan
---------
`gc_sync_after_sync.py` and `gc_sync_after_sync.py swap` both pass locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kouprin Kouprin

Labels
A-chain Area: Chain, client & related
Projects
None yet
Milestone
No milestone
2 participants
@SkidanovAlex @Kouprin