Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --boot-nodes argument to neard init #3156

Closed
frol opened this issue Aug 13, 2020 · 3 comments
Closed

Introduce --boot-nodes argument to neard init #3156

frol opened this issue Aug 13, 2020 · 3 comments
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. Node Node team T-node Team: issues relevant to the node experience team T-public-interfaces Team: issues relevant to the public interfaces team

Comments

@frol
Copy link
Collaborator

frol commented Aug 13, 2020

As per an offline discussion with @khorolets @bowenwang1996 @chefsale, the extension to neard init has been suggested to address the empty boot_nodes upon the default config generation (currently, when you run a node with neard init + neard run you will get "waiting for peers" message due to the fact that the default config generated by neard init does not have any boot nodes in it).

If we add --boot-nodes CLI argument we can enable nearcore users to select the list of trusted nodes and initialize their config with a single neard init command.

The relevant point where we want to alter the config during initialization is:

https://github.com/nearprotocol/nearcore/blob/82501aecfc4493218987872de5c71cc99a777e5a/neard/src/config.rs#L734-L736

(NOTE, this is the link to the testnet/betanet initialization while there are two more branches there, which also need to populate boot nodes)

This issue is also part of near/nearup#81 initiative. Currently, neard init produces a config that is not immediately useful, and we rely on nearup to download the config from https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/nearcore-deploy/testnet/config.json

@frol frol added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Aug 13, 2020
@chefsale chefsale added the T-SRE Team: issues relevant to the SRE team label Aug 13, 2020
@frol
Copy link
Collaborator Author

frol commented Aug 28, 2020

Consider also fixing #1655 when you are implementing this.

@frol frol added bootcamp B-L3 Bootcamp: (“Task”) medium 10-50 line code change labels Jun 3, 2021
@frol frol added T-public-interfaces Team: issues relevant to the public interfaces team and removed T-SRE Team: issues relevant to the SRE team labels Jun 18, 2021
@janewang janewang added the T-node Team: issues relevant to the node experience team label Jun 18, 2021
@janewang janewang added this to Backlog in Node Experience Q3 2021 via automation Jun 18, 2021
@janewang janewang moved this from Backlog to Incoming Requests (To Be Groomed) in Node Experience Q3 2021 Jun 22, 2021
@chefsale
Copy link
Contributor

I have implemented a --download-config flag which use the boot nodes specified on the S3 config.json files in: #4427. Now last step is also to add this flag to override the current configs.

@chefsale
Copy link
Contributor

chefsale commented Jul 2, 2021

Created a PR which adds boot nodes to the init command: #4453

@chefsale chefsale removed B-L3 Bootcamp: (“Task”) medium 10-50 line code change C-bootcamp labels Jul 2, 2021
@chefsale chefsale closed this as completed Jul 6, 2021
Node Experience Q3 2021 automation moved this from Incoming Requests (To Be Groomed) to Done Jul 6, 2021
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. Node Node team T-node Team: issues relevant to the node experience team T-public-interfaces Team: issues relevant to the public interfaces team
Development

No branches or pull requests

4 participants