Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass shard_layout to garbage collection #4710

Closed
mzhangmzz opened this issue Aug 18, 2021 · 0 comments · Fixed by #5040
Closed

Pass shard_layout to garbage collection #4710

mzhangmzz opened this issue Aug 18, 2021 · 0 comments · Fixed by #5040
Assignees
@mzhangmzz
Labels
A-chain Area: Chain, client & related A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) P-critical Priority: critical T-core Team: issues relevant to the core team
Projects
Chain + Transaction Runtime Q3

Comments

@mzhangmzz
Copy link
Contributor

After #4659, Trie nodes are stored in the database with shard_version as part of their keys. However, the pull request didn't finish changing garbage collection to make it take the correct shard_version to garbage collect. It is left as a TODO there.

This issue needs to be fixed before sharding is enabled, otherwise gc will not work correctly
@mzhangmzz mzhangmzz added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Aug 18, 2021
@mzhangmzz mzhangmzz mentioned this issue Aug 18, 2021
Merged
@mzhangmzz mzhangmzz self-assigned this Aug 18, 2021
@mzhangmzz mzhangmzz added this to New Issues in Chain + Transaction Runtime Q3 via automation Aug 18, 2021
@bowenwang1996 bowenwang1996 added T-core Team: issues relevant to the core team A-chain Area: Chain, client & related labels Aug 19, 2021
@mzhangmzz mzhangmzz mentioned this issue Sep 1, 2021
Merged
@mzhangmzz mzhangmzz pinned this issue Oct 19, 2021
@mzhangmzz mzhangmzz unpinned this issue Oct 19, 2021
@mzhangmzz mzhangmzz added the P-critical Priority: critical label Oct 19, 2021
@mzhangmzz mzhangmzz mentioned this issue Oct 20, 2021
Merged
Chain + Transaction Runtime Q3 automation moved this from New Issues to Done Oct 22, 2021
near-bulldozer bot pushed a commit that referenced this issue Oct 22, 2021
@mzhangmzz
fix gc for sharding upgrade (#5040)
e2bf006 
resolve #4710

Also added a python test for gc with sharding upgrade
bowenwang1996 pushed a commit that referenced this issue Oct 26, 2021
@mzhangmzz @bowenwang1996
fix gc for sharding upgrade (#5040)
07d87cb 
resolve #4710

Also added a python test for gc with sharding upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzhangmzz mzhangmzz

Labels
A-chain Area: Chain, client & related A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) P-critical Priority: critical T-core Team: issues relevant to the core team
Projects
Chain + Transaction Runtime Q3
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix gc for sharding upgrade near/nearcore
2 participants
@bowenwang1996 @mzhangmzz