-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong genesis config in EXPEIMENTAL_protocol_config #9553
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 17, 2023
…9692) Testing this PR on a testnet node, the diff with results from an rpc node is the following. Both changes look good to me. ``` 10c10 < "chunk_producer_kickout_threshold": 90, --- > "chunk_producer_kickout_threshold": 80, 28c28 < "num_block_producer_seats": 200, --- > "num_block_producer_seats": 100, ``` Proofs: * https://github.com/near/nearcore/blob/a5238cc70e268fe6da218c8367b053d53711ac6f/core/primitives/src/epoch_manager.rs#L134 * https://github.com/near/nearcore/blob/6f324e84a7a7162956f0b9985094ee146919f5ae/core/primitives/src/epoch_manager.rs#L149 Fix #9553 Also adds new fields to the response: * shard_layout * num_chunk_only_producer_seats * minimum_validators_per_shard * minimum_stake_ratio * max_kickout_stake_perc --------- Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me>
nikurt
added a commit
that referenced
this issue
Oct 18, 2023
…9692) Testing this PR on a testnet node, the diff with results from an rpc node is the following. Both changes look good to me. ``` 10c10 < "chunk_producer_kickout_threshold": 90, --- > "chunk_producer_kickout_threshold": 80, 28c28 < "num_block_producer_seats": 200, --- > "num_block_producer_seats": 100, ``` Proofs: * https://github.com/near/nearcore/blob/a5238cc70e268fe6da218c8367b053d53711ac6f/core/primitives/src/epoch_manager.rs#L134 * https://github.com/near/nearcore/blob/6f324e84a7a7162956f0b9985094ee146919f5ae/core/primitives/src/epoch_manager.rs#L149 Fix #9553 Also adds new fields to the response: * shard_layout * num_chunk_only_producer_seats * minimum_validators_per_shard * minimum_stake_ratio * max_kickout_stake_perc --------- Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me>
nikurt
added a commit
that referenced
this issue
Oct 20, 2023
…9692) Testing this PR on a testnet node, the diff with results from an rpc node is the following. Both changes look good to me. ``` 10c10 < "chunk_producer_kickout_threshold": 90, --- > "chunk_producer_kickout_threshold": 80, 28c28 < "num_block_producer_seats": 200, --- > "num_block_producer_seats": 100, ``` Proofs: * https://github.com/near/nearcore/blob/a5238cc70e268fe6da218c8367b053d53711ac6f/core/primitives/src/epoch_manager.rs#L134 * https://github.com/near/nearcore/blob/6f324e84a7a7162956f0b9985094ee146919f5ae/core/primitives/src/epoch_manager.rs#L149 Fix #9553 Also adds new fields to the response: * shard_layout * num_chunk_only_producer_seats * minimum_validators_per_shard * minimum_stake_ratio * max_kickout_stake_perc --------- Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me>
nikurt
added a commit
that referenced
this issue
Oct 20, 2023
…9692) Testing this PR on a testnet node, the diff with results from an rpc node is the following. Both changes look good to me. ``` 10c10 < "chunk_producer_kickout_threshold": 90, --- > "chunk_producer_kickout_threshold": 80, 28c28 < "num_block_producer_seats": 200, --- > "num_block_producer_seats": 100, ``` Proofs: * https://github.com/near/nearcore/blob/a5238cc70e268fe6da218c8367b053d53711ac6f/core/primitives/src/epoch_manager.rs#L134 * https://github.com/near/nearcore/blob/6f324e84a7a7162956f0b9985094ee146919f5ae/core/primitives/src/epoch_manager.rs#L149 Fix #9553 Also adds new fields to the response: * shard_layout * num_chunk_only_producer_seats * minimum_validators_per_shard * minimum_stake_ratio * max_kickout_stake_perc --------- Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
But the value is actually
100
, not200
:nearcore/core/primitives/src/epoch_manager.rs
Line 134 in a5238cc
The text was updated successfully, but these errors were encountered: