Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neard-sandbox built @master from source panics at runtime #9665

Closed
shariffdev opened this issue Oct 11, 2023 · 4 comments · Fixed by #9691
Closed

neard-sandbox built @master from source panics at runtime #9665

shariffdev opened this issue Oct 11, 2023 · 4 comments · Fixed by #9691
Assignees

Comments

@shariffdev
Copy link

shariffdev commented Oct 11, 2023

Describe the bug
There is a panic at runtime running neard-sandbox built from source @master. An example is when running the workspace-rs tests. The panic does not happen when using the latest nearcore release branch 1.35.0 https://github.com/near/nearcore

To Reproduce
Build neard-sandbox from source:

git clone https://github.com/near/nearcore.git
cd nearcore
make sandbox-release

Run workspase-rs tests locally:

git clone https://github.com/near/near-workspaces-rs.git
cd near-workspaces-rs
NEAR_SANDBOX_BIN_PATH="/path/to/built/neard-sandbox" NEAR_RPC_TIMEOUT_SECS=100 cargo test --verbose --features unstable

Expected behavior
Tests should run normally as in @1.35.0

Screenshots
Screenshot 2023-10-11 at 09 21 58

Version (please complete the following information):

  • nearcore: @master #3a56da2b76b280f7e0c42d4b4d3242b519908201
  • rust version: rustc 1.73.0 (cc66ad468 2023-10-03)
  • feature(s): sandbox
  • system: macOS

Additional Context
I've played around with toggling sandbox and near_vm features and not found a simple fix. But I could be wrong.

@frol
Copy link
Collaborator

frol commented Oct 13, 2023

@shariffdev I can reproduce it on my side with the commit you referenced, but after that there was PR #9658 that stabilized the restriction for creation of top-level accounts, and so top-level accounts (dev-xxxxxx-xxxxx) cannot be created anymore without registrar, so this issue is masked. Please, adjust near-workspaces-rs to either (1) use the root account to create sub-accounts as dev accounts (instead of dev-xxxxx-xxxxx, create dev-xxxxx-xxxxx.sandnet or whatever we use for the root account id there); OR (2) use registrar account to continue creating dev-xxxxx-xxxxx accounts - whichever path will be faster to hack, so we can test and reproduce the issue.

@shariffdev
Copy link
Author

@frol thanks for the strategies. I was able to recreate the issue still. Heres the workaround: https://github.com/shariffdev/workspaces-rs/tree/hack/tla-acc-id

@shariffdev
Copy link
Author

I could not find the "registrar" account info, there was the validator_key and the node_key when initialising sandbox. Is it stored somewhere accessible?

@bowenwang1996
Copy link
Collaborator

@frol on the topic of top-level accounts, could workspace adjust the config in the local environment that it spins up? #9658 changes only the config value (32 -> 63).

@nagisa nagisa self-assigned this Oct 14, 2023
nagisa added a commit that referenced this issue Oct 16, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nagisa added a commit that referenced this issue Oct 16, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nagisa added a commit that referenced this issue Oct 16, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nikurt pushed a commit that referenced this issue Oct 17, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nikurt pushed a commit that referenced this issue Oct 17, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nikurt pushed a commit that referenced this issue Oct 20, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
nikurt pushed a commit that referenced this issue Oct 20, 2023
People with M1 Macs run the neard node too, not just the test suites.
Unfortunately a proper regression test for this is not obvious… I’ll
think about it.

(Possibly)
Fixes #9665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants