Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three failures in txflow tests #99

Closed
SkidanovAlex opened this issue Nov 28, 2018 · 4 comments
Closed

Three failures in txflow tests #99

SkidanovAlex opened this issue Nov 28, 2018 · 4 comments
Assignees
@mikhailOK
Labels
C-bug Category: This is a bug
Milestone
AlphaNet

Comments

@SkidanovAlex
Copy link
Collaborator

There are three generated tests failing. Here are the tests and the reasons:

bob_fork

Alice approves two messages from Bob, neither shall be considered an endorsements. Carol and Dave only approve one, both such approvals shall be endorsements.

bob_second_msg_in_kickout_epoch

Bob has a message that approves his own kickout message in the same epoch. Rust implementation mistakenly marks such message as kickout as well.

generated_kickouts_and_epoch_blocks_1

For some reason Carol's message is not a representative, even though it approves the previous representative, and its own kickout message has sufficient number of endorsements.
@SkidanovAlex SkidanovAlex added the C-bug Category: This is a bug label Nov 28, 2018
@SkidanovAlex SkidanovAlex added this to the MVB milestone Nov 28, 2018
SkidanovAlex added a commit that referenced this issue Nov 28, 2018
@SkidanovAlex
TxFlow testgen now also tests endorsements
749135b 
Also added a nodejs script that generates all the tests at once.
This particular part can still be significantly imporived.

The generated tests found three bugs, all three are tracked by #99, for now tests are marked as `should-panic`
@SkidanovAlex SkidanovAlex mentioned this issue Nov 28, 2018
Merged
MaksymZavershynskyi pushed a commit that referenced this issue Nov 29, 2018
@SkidanovAlex @MaksymZavershynskyi
TxFlow testgen now also tests endorsements (#100)
78c2d4a 
Also added a nodejs script that generates all the tests at once.
This particular part can still be significantly imporived.

The generated tests found three bugs, all three are tracked by #99, for now tests are marked as `should-panic`
@mfornet mfornet mentioned this issue Dec 1, 2018
Closed
@MaksymZavershynskyi
Copy link
Contributor

Blocked on #125

@ilblackdragon
Copy link
Member

@SkidanovAlex @nearmax @mikhailOK is still open?

@MaksymZavershynskyi
Copy link
Contributor

Yes. Needs new implementation by @mikhailOK

@MaksymZavershynskyi
Copy link
Contributor

TxFlow is getting removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikhailOK mikhailOK

Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
AlphaNet
Development

No branches or pull requests
4 participants
@ilblackdragon @SkidanovAlex @mikhailOK @MaksymZavershynskyi