fix: use header_head to determine validators for forwarding transactions #10256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10256 +/- ##
==========================================
- Coverage 71.86% 71.86% -0.01%
==========================================
Files 707 707
Lines 142244 142237 -7
Branches 142244 142237 -7
==========================================
- Hits 102219 102212 -7
- Misses 35302 35308 +6
+ Partials 4723 4717 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nikurt
added a commit
that referenced
this pull request
Dec 6, 2023
…ons (#10256) Functions `find_chunk_producer_for_forwarding()`, `find_validator_for_forwarding()` are not used much, one calls another, and they both call `chain.head()`. That seems unnecessary. Refactored to call `get_chunk_producer()` directly, and not worry about 3 layers of functions using different types of heads. See #10251 for context (cherry picked from commit 3a33ff5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
find_chunk_producer_for_forwarding(),find_validator_for_forwarding()are not used much, one calls another, and they both callchain.head().That seems unnecessary. Refactored to call
get_chunk_producer()directly, and not worry about 3 layers of functions using different types of heads.See #10251 for context