estimator: clean up the plugin build code and uncheckout binaries #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin is trivial to build, I don't see a good reason to keep the binaries checked in, especially given that the docker container should be providing the relevant reproducible build environment for the plugin anyhow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10607 +/- ##
==========================================
+ Coverage 72.12% 72.14% +0.01%
==========================================
Files 725 725
Lines 147512 147512
Branches 147512 147512
==========================================
+ Hits 106397 106424 +27
+ Misses 36325 36304 -21
+ Partials 4790 4784 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akhi3030
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin is trivial to build, I don't see a good reason to keep the binaries checked in, especially given that the docker container should be providing the relevant reproducible build environment for the plugin anyhow.