Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error description in InvalidChunkStateWitness error #10622

Merged
merged 1 commit into from Feb 16, 2024

Conversation

jancionear
Copy link
Contributor

This error variant contains a String with additional description, but it isn't printed when the error is displayed.
Let's print the description to make errors clearer, it'll make debugging things easier.

This error variant contains a String with additional description
let's print this description to make errors clearer.
@jancionear jancionear requested a review from a team as a code owner February 15, 2024 17:33
@jancionear jancionear added the A-stateless-validation Area: stateless validation label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69c3923) 72.19% compared to head (e447681) 72.17%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10622      +/-   ##
==========================================
- Coverage   72.19%   72.17%   -0.02%     
==========================================
  Files         726      726              
  Lines      147719   147719              
  Branches   147719   147719              
==========================================
- Hits       106647   106620      -27     
- Misses      36272    36289      +17     
- Partials     4800     4810      +10     
Flag Coverage Δ
backward-compatibility 0.08% <ø> (ø)
db-migration 0.08% <ø> (ø)
genesis-check 1.24% <ø> (ø)
integration-tests 37.05% <ø> (-0.01%) ⬇️
linux 71.20% <ø> (-0.02%) ⬇️
linux-nightly 71.60% <ø> (-0.02%) ⬇️
macos 55.10% <ø> (+0.22%) ⬆️
pytests 1.46% <ø> (ø)
sanity-checks 1.26% <ø> (ø)
unittests 68.08% <ø> (-0.03%) ⬇️
upgradability 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robin-near robin-near left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, didn't know that was possible :)

@robin-near robin-near added this pull request to the merge queue Feb 16, 2024
Merged via the queue into near:master with commit 99f7c15 Feb 16, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants