Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lychee lints #10644

Merged
merged 1 commit into from Feb 21, 2024
Merged

fix lychee lints #10644

merged 1 commit into from Feb 21, 2024

Conversation

Ekleog-NEAR
Copy link
Collaborator

No description provided.

Copy link
Contributor

@jancionear jancionear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing ❤️

@@ -2,6 +2,7 @@ exclude = [
# these are private repositories, presumably any link to it are in internal documentation only.
"^https://github.com/near/near-ops",
"^https://github.com/near/nearcore-private",
"^https://github.com/PagodaPlatform/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all repos in PagodaPlatform are private, maybe it would be better to exclude only https://github.com/PagodaPlatform/tf-near-node which is currently failing?

@Ekleog-NEAR Ekleog-NEAR added this pull request to the merge queue Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03813d8) 72.31% compared to head (0813e10) 72.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10644      +/-   ##
==========================================
- Coverage   72.31%   72.29%   -0.02%     
==========================================
  Files         730      730              
  Lines      149146   149146              
  Branches   149146   149146              
==========================================
- Hits       107852   107830      -22     
- Misses      36454    36472      +18     
- Partials     4840     4844       +4     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.35% <ø> (ø)
integration-tests 36.86% <ø> (-0.02%) ⬇️
linux 71.18% <ø> (-0.02%) ⬇️
linux-nightly 71.72% <ø> (-0.02%) ⬇️
macos 55.31% <ø> (+<0.01%) ⬆️
pytests 1.57% <ø> (ø)
sanity-checks 1.36% <ø> (ø)
unittests 68.18% <ø> (-0.02%) ⬇️
upgradability 0.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit db5b0b3 Feb 21, 2024
29 checks passed
@Ekleog-NEAR Ekleog-NEAR deleted the fix-lychee branch February 21, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants