Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix feature = "cargo-clippy" deprecation #10679

Merged
merged 1 commit into from Feb 28, 2024
Merged

fix: fix feature = "cargo-clippy" deprecation #10679

merged 1 commit into from Feb 28, 2024

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 28, 2024

@rex4539 rex4539 requested a review from a team as a code owner February 28, 2024 15:47
@akhi3030
Copy link
Collaborator

Thanks for the PR, it looks good. I'm assuming that you do not plan on adding more commits to this PR and I will click the "merge when ready" button.

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (4f8124a) to head (23310f2).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10679      +/-   ##
==========================================
- Coverage   72.28%   72.25%   -0.03%     
==========================================
  Files         735      735              
  Lines      150535   150535              
  Branches   150535   150535              
==========================================
- Hits       108809   108772      -37     
- Misses      36790    36824      +34     
- Partials     4936     4939       +3
Flag Coverage Δ
backward-compatibility 0.24% <ø> (ø)
db-migration 0.24% <ø> (ø)
genesis-check 1.41% <ø> (ø)
integration-tests 37.09% <ø> (-0.06%) ⬇️
linux 71.07% <ø> (+0.01%) ⬆️
linux-nightly 71.68% <ø> (-0.05%) ⬇️
macos 55.30% <ø> (-0.01%) ⬇️
pytests 1.63% <ø> (ø)
sanity-checks 1.42% <ø> (ø)
unittests 68.07% <ø> (-0.05%) ⬇️
upgradability 0.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nagisa
nagisa reviewed Feb 28, 2024
View reviewed changes
runtime/near-vm/compiler/src/lib.rs
@@ -8,9 +8,9 @@
#![deny(missing_docs, trivial_numeric_casts, unused_extern_crates)]
#![warn(unused_import_braces)]
#![deny(unstable_features)]
#![cfg_attr(feature = "cargo-clippy", allow(clippy::new_without_default))]
#![cfg_attr(clippy, allow(clippy::new_without_default))]
Copy link
Collaborator

@nagisa nagisa Feb 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These no longer need to be cfg_attrd at all to the best of my knowledge. Fine to leave as-is too though.

@nagisa
Copy link
Collaborator

nagisa commented Feb 28, 2024

Looks like the CI is failing due to formatting. cargo fmt should suffice.

auto-merge was automatically disabled February 28, 2024 17:02

Head branch was pushed to by a user without write access

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 28, 2024

Should be ok now

@akhi3030 akhi3030 added this pull request to the merge queue Feb 28, 2024
Merged via the queue into near:master with commit 902f155 Feb 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa left review comments

@akhi3030 akhi3030 akhi3030 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rex4539 @akhi3030 @nagisa