[fix] Fix Linux StatelessNet Github CI #10731
Conversation
shreyan-gupta
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10731 +/- ##
==========================================
+ Coverage 71.66% 71.69% +0.02%
==========================================
Files 756 756
Lines 152299 152398 +99
Branches 152299 152398 +99
==========================================
+ Hits 109150 109259 +109
+ Misses 38186 38160 -26
- Partials 4963 4979 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Since the snapshots haven't actually changed, what's the difference here? |
If we take a look at some of the earlier runs, the main set of tests failing are Now I don't know what exactly is going on, but these were disabled for nightly probably due to the snapshots changing after applying all the protocol version deltas. For statelessnet the tests expect the snapshot to have the new value from delta 83, which means if we include that change, the snapshot aggregation till protocol 64 would fail. https://github.com/near/nearcore/actions/runs/8195058269/job/22412472140?pr=10725 |
| @@ -611,12 +611,12 @@ impl From<ExtCostsConfigView> for crate::ExtCostsConfig { | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| #[cfg(not(feature = "nightly"))] | |||
| #[cfg(not(feature = "statelessnet_protocol"))] | |||
There was a problem hiding this comment.
FWIW I still prefer ignore as it allows the test runner to see the total number of tests and indicate which ones have been ignored, but its not serious enough to block the PR over it.
There was a problem hiding this comment.
Will keep in mind and change in some future random PR!
Runtime config check related tests are not supposed to run on nightly and statelessnet.
Originally broken in #10703