Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11135 #11153

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fix #11135 #11153

merged 5 commits into from
Apr 25, 2024

Conversation

bowenwang1996
Copy link
Collaborator

@bowenwang1996 bowenwang1996 commented Apr 25, 2024

@Longarithm fixed #11135 by forcing flat storage head to move after state sync. The pytest single_shard_tracking exposes this issue.

Instructions to run the test

cargo build -p neard --features test_features,statelessnet_protocol
python3 pytest/tests/sanity/single_shard_tracking.py

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 71.00%. Comparing base (6aa1aad) to head (ea88c1c).

Files Patch % Lines
chain/chain/src/chain.rs 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11153      +/-   ##
==========================================
- Coverage   71.02%   71.00%   -0.03%     
==========================================
  Files         773      773              
  Lines      154349   154361      +12     
  Branches   154349   154361      +12     
==========================================
- Hits       109630   109600      -30     
- Misses      40270    40314      +44     
+ Partials     4449     4447       -2     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (-0.01%) ⬇️
db-migration 0.24% <0.00%> (-0.01%) ⬇️
genesis-check 1.42% <0.00%> (-0.01%) ⬇️
integration-tests 36.86% <75.00%> (-0.01%) ⬇️
linux 69.43% <75.00%> (-0.01%) ⬇️
linux-nightly 70.44% <75.00%> (-0.05%) ⬇️
macos 54.24% <43.75%> (+0.01%) ⬆️
pytests 1.65% <0.00%> (-0.01%) ⬇️
sanity-checks 1.44% <0.00%> (-0.01%) ⬇️
unittests 66.67% <43.75%> (-0.02%) ⬇️
upgradability 0.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Longarithm and others added 2 commits April 25, 2024 18:11
@bowenwang1996 bowenwang1996 changed the title [DO NOT MERGE] pytest that reproduces #11135 Fix #11135 Apr 25, 2024
@bowenwang1996 bowenwang1996 marked this pull request as ready for review April 25, 2024 16:15
@bowenwang1996 bowenwang1996 requested a review from a team as a code owner April 25, 2024 16:15
@Longarithm
Copy link
Member

Fixed test test_dump_epoch_missing_chunk_in_last_block because in test envs flat storage is not always present.
Added test to nayduck: https://nayduck.nearone.org/#/run/67
Let's also remove extensive debug output.

@bowenwang1996
Copy link
Collaborator Author

bowenwang1996 commented Apr 25, 2024

@tayfunelmas @Longarithm could you approve this PR?

@tayfunelmas
Copy link
Contributor

@tayfunelmas @Longarithm could you approve this PR?

Approved, but still need an owner approval.

Copy link
Contributor

@shreyan-gupta shreyan-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping

@bowenwang1996 bowenwang1996 added this pull request to the merge queue Apr 25, 2024
Merged via the queue into near:master with commit 4ea04e4 Apr 25, 2024
27 of 29 checks passed
@bowenwang1996 bowenwang1996 deleted the missing-chunk-extra-repro branch April 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stateless_validation] Missing ChunkExtra on load memtrie on startup
4 participants