fix(mirror): queue fake blocks for initial create account txs #11336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e301c09 from near#11325. This small commit was not necessary, and actually incorrect, because there's an assumption that changed access keys will only appear in SentBatch::MappedBlock(). Otherwise we hit an assertion here: https://github.com/near/nearcore/blob/510948178c5920c614448dc7bcce72873a1655fd/tools/mirror/src/chain_tracker.rs#L1026
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11336 +/- ##
=======================================
Coverage 71.03% 71.04%
=======================================
Files 783 783
Lines 156790 156797 +7
Branches 156790 156797 +7
=======================================
+ Hits 111381 111400 +19
+ Misses 40594 40575 -19
- Partials 4815 4822 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e301c09 from #11325. This small commit was not necessary, and actually incorrect, because there's an assumption that changed access keys will only appear in SentBatch::MappedBlock(). Otherwise we hit an assertion here:
nearcore/tools/mirror/src/chain_tracker.rs
Line 1026 in 5109481