vm: simplify calculation of entrypoint index #11365
Merged
+14
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11365 +/- ##
==========================================
+ Coverage 71.07% 71.17% +0.09%
==========================================
Files 783 784 +1
Lines 156719 157177 +458
Branches 156719 157177 +458
==========================================
+ Hits 111394 111870 +476
+ Misses 40502 40470 -32
- Partials 4823 4837 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was a headscratcher to me as I ended up with the two blocks in the same area and the `Err` branch in the 2nd block seemed unreachable to me. At first I thought that maybe this is a holdover from wasmer2 times, but it is the same there!
nagisa
force-pushed
the
simplifies-entrypoint-index
branch
from
c49f261
to
11d62e9
Compare
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
May 23, 2024
This was a headscratcher to me as I ended up with the two blocks in the same area and the `Err` branch in the 2nd block seemed unreachable to me (and there were not any side-effects in between.) At first I thought that maybe this is a holdover from wasmer2 times, but it is the same there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a headscratcher to me as I ended up with the two blocks in the same area and the
Errbranch in the 2nd block seemed unreachable to me (and there were not any side-effects in between.) At first I thought that maybe this is a holdover from wasmer2 times, but it is the same there!