feat(forknet): allow running traffic generator with a key map secret #11375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we've been using the mirror tool without a secret used to map keys, which is fine when we're running internal tests. but if we want to start a forknet instance that will later be opened up to the public, we'll want to use a mix the mapped keys with a secret. so here we will assume that it will be placed in ~/.near/setup/mirror-secret.json (or ~/.near/target/setup/mirror-secret.json for V2 setups) and we'll use it if so
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11375 +/- ##
=======================================
Coverage 71.20% 71.20%
=======================================
Files 784 784
Lines 157224 157224
Branches 157224 157224
=======================================
+ Hits 111952 111959 +7
+ Misses 40423 40420 -3
+ Partials 4849 4845 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
approved these changes
May 22, 2024
marcelo-gonzalez
added a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
May 23, 2024
…ear#11375) we've been using the mirror tool without a secret used to map keys, which is fine when we're running internal tests. but if we want to start a forknet instance that will later be opened up to the public, we'll want to use a mix the mapped keys with a secret. so here we will assume that it will be placed in ~/.near/setup/mirror-secret.json (or ~/.near/target/setup/mirror-secret.json for V2 setups) and we'll use it if so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've been using the mirror tool without a secret used to map keys, which is fine when we're running internal tests. but if we want to start a forknet instance that will later be opened up to the public, we'll want to use a mix the mapped keys with a secret. so here we will assume that it will be placed in ~/.near/setup/mirror-secret.json (or ~/.near/target/setup/mirror-secret.json for V2 setups) and we'll use it if so