bench/db: update ft_transfers schema
#11563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooori
commented
Jun 13, 2024
| @@ -121,6 +121,7 @@ def commit_to_db(data: dict) -> None: | |||
| commit_hash, commit_time = get_commit() | |||
| response = { | |||
| "time": time_begin.strftime('%Y-%m-%dT%H:%M:%SZ'), | |||
| "time_end": datetime.now().strftime('%Y-%m-%dT%H:%M:%SZ'), | |||
There was a problem hiding this comment.
@MCJOHN974 can you verify if this is the correct way to add time_end to the response?
MCJOHN974
approved these changes
Jun 13, 2024
akashin
reviewed
Jun 13, 2024
benchmarks/continous/db/tool/orm/migrations/2024-06-12-120242_refine_ft_transfers/down.sql
Outdated
Show resolved
Hide resolved
akashin
reviewed
Jun 13, 2024
benchmarks/continous/db/tool/orm/migrations/2024-06-12-120242_refine_ft_transfers/down.sql
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11563 +/- ##
==========================================
- Coverage 71.48% 71.47% -0.01%
==========================================
Files 788 788
Lines 160835 160835
Branches 160835 160835
==========================================
- Hits 114968 114956 -12
- Misses 40850 40863 +13
+ Partials 5017 5016 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@akashin, @MCJOHN974 could you please take another look, I've added a new migration as discussed on Zulip:
|
akashin
approved these changes
Jun 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
- Adds a `time_end` field to allow recording both the start and end time of benchmark runs. This was requested in an issue which I couldn't find anymore in a quick search. - Values of `total_transactions` and `size_state_bytes` might get out of the `integer` range, hence the type of these columns is changed to `bigint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time_endfield to allow recording both the start and end time of benchmark runs. This was requested in an issue which I couldn't find anymore in a quick search.total_transactionsandsize_state_bytesmight get out of theintegerrange, hence the type of these columns is changed tobigint.