network: pick STUN server to match node_addr IP version #11628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11628 +/- ##
==========================================
- Coverage 71.46% 71.46% -0.01%
==========================================
Files 788 788
Lines 160854 160867 +13
Branches 160854 160867 +13
==========================================
+ Hits 114958 114964 +6
- Misses 40876 40877 +1
- Partials 5020 5026 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Jun 20, 2024
28 tasks
saketh-are
added a commit
that referenced
this pull request
Jun 25, 2024
When nodes query an address such as `stun.l.google.com:19302` for which there exist both IPv4 and IPv6 records, `tokio::net::UdpSocket::connect` chooses one arbitrarily. We should make sure to query the appropriate server based on the IP version of the node's TCP listener address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nodes query an address such as
stun.l.google.com:19302for which there exist both IPv4 and IPv6 records,tokio::net::UdpSocket::connectchooses one arbitrarily.We should make sure to query the appropriate server based on the IP version of the node's TCP listener address.