Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert db version 40 #11635

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

Longarithm
Copy link
Member

@Longarithm Longarithm commented Jun 20, 2024

I tried #11569 to solve validator kickout enum issue to get mainnet and statelessnet aligned. But because we reset statelessnet, we can get all ValidatorKickoutReasons in line. This is the easiest solution.

DB version for latest release is 38, so removing 40 is not an issue. 39 must stay.

@Longarithm Longarithm requested a review from a team as a code owner June 20, 2024 16:34
@Longarithm Longarithm added this pull request to the merge queue Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (c2315ca) to head (7e2b85f).
Report is 1 commits behind head on master.

Files Patch % Lines
core/store/src/migrations.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11635      +/-   ##
==========================================
+ Coverage   71.55%   71.58%   +0.03%     
==========================================
  Files         787      787              
  Lines      160761   160736      -25     
  Branches   160761   160736      -25     
==========================================
+ Hits       115030   115064      +34     
+ Misses      40708    40633      -75     
- Partials     5023     5039      +16     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (+<0.01%) ⬆️
db-migration 0.23% <0.00%> (+<0.01%) ⬆️
genesis-check 1.36% <0.00%> (+<0.01%) ⬆️
integration-tests 37.66% <0.00%> (-0.04%) ⬇️
linux 68.99% <0.00%> (+0.01%) ⬆️
linux-nightly 71.08% <0.00%> (+0.03%) ⬆️
macos 52.57% <0.00%> (+1.29%) ⬆️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.39% <0.00%> (+<0.01%) ⬆️
unittests 66.16% <0.00%> (+0.03%) ⬆️
upgradability 0.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 9f5b03e Jun 20, 2024
28 of 30 checks passed
@Longarithm Longarithm deleted the revert-migration-40 branch June 20, 2024 17:30
Longarithm added a commit that referenced this pull request Jun 20, 2024
I tried #11569 to solve validator kickout enum issue to get mainnet and
statelessnet aligned. But because we reset statelessnet, we can get all
ValidatorKickoutReasons in line. This is the easiest solution.

DB version for latest release is 38, so removing 40 is not an issue. 39
must stay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants