[stateless_validation] Fix to store state witness from prev block of epoch before stateless validation #11638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epoch before stateless validation
tayfunelmas
reviewed
Jun 20, 2024
chain/chain/src/chain.rs
Outdated
| @@ -3524,8 +3524,12 @@ impl Chain { | |||
| } | |||
| let epoch_id = block_header.epoch_id(); | |||
| // Use epoch manager because block is not in DB yet. | |||
| // Let "epoch" be the epoch at which we enable stateless validation. | |||
| // We need to start storing the state witness from the last block of the previous epoch. | |||
There was a problem hiding this comment.
nit. storing -> generating/sending
There was a problem hiding this comment.
Let me go with "producing" as that's the wording of this function call.
tayfunelmas
approved these changes
Jun 20, 2024
Longarithm
reviewed
Jun 20, 2024
| let next_epoch_id = | ||
| self.epoch_manager.get_next_epoch_id_from_prev_block(block_header.prev_hash())?; | ||
| self.epoch_manager.get_next_epoch_id_from_prev_block(block_header.hash())?; |
There was a problem hiding this comment.
Sanity check - will it work if the last block doesn't have a chunk, so for main transition this will be false?
|
This is not the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bowen identified this issue with protocol upgrade where we were not storing the chunk state witness for the last block of epoch before stateless validation. This PR is a fix for that.
In a future PR we would write a test for protocol upgrade.