Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Reduced dependencies for various near_* crates #11639

Merged
merged 13 commits into from
Jun 28, 2024

Conversation

akorchyn
Copy link
Contributor

@akorchyn akorchyn commented Jun 20, 2024

Compilation unit reduction:

  • near-jsonrpc-primitives: 324 -> 181
  • near-chain-configs: 321 -> 170
  • near-chain-primitives: 325 -> 170
  • near-client-primitives: 325 -> 215
  • near-store: 414 -> 407 (this is actually not that great, but still an improvement. Also, I think we can extract metrics into a feature to improve compile time :)

@akorchyn akorchyn requested a review from a team as a code owner June 20, 2024 19:11
@akorchyn akorchyn requested a review from Longarithm June 20, 2024 19:11
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (fc6f94b) to head (22d4ae1).
Report is 1 commits behind head on master.

Files Patch % Lines
tools/ping/src/lib.rs 0.00% 8 Missing ⚠️
tools/state-parts/src/lib.rs 0.00% 3 Missing ⚠️
core/primitives/src/block_header.rs 90.90% 1 Missing ⚠️
tools/ping/src/csv.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11639      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.02%     
==========================================
  Files         788      788              
  Lines      161256   161263       +7     
  Branches   161256   161263       +7     
==========================================
- Hits       115552   115531      -21     
- Misses      40674    40699      +25     
- Partials     5030     5033       +3     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (-0.01%) ⬇️
db-migration 0.23% <0.00%> (-0.01%) ⬇️
genesis-check 1.35% <2.94%> (-0.01%) ⬇️
integration-tests 37.83% <58.33%> (+<0.01%) ⬆️
linux 69.05% <63.88%> (+<0.01%) ⬆️
linux-nightly 71.13% <63.88%> (-0.02%) ⬇️
macos 52.65% <50.00%> (+1.62%) ⬆️
pytests 1.59% <2.94%> (-0.01%) ⬇️
sanity-checks 1.38% <2.94%> (-0.01%) ⬇️
unittests 66.24% <50.00%> (-0.01%) ⬇️
upgradability 0.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I left comments mostly for readability, because I was not very familiar with the goal and the approach before.

core/store/Cargo.toml Outdated Show resolved Hide resolved
core/async/Cargo.toml Outdated Show resolved Hide resolved
core/store/Cargo.toml Outdated Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/dependencies.rs Outdated Show resolved Hide resolved
@akorchyn akorchyn requested a review from Longarithm June 23, 2024 18:19
@akorchyn
Copy link
Contributor Author

As you have mentioned, I have created a new issue: #11652

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing, thank you for your contribution!

core/async/Cargo.toml Outdated Show resolved Hide resolved
@akorchyn
Copy link
Contributor Author

@Longarithm Hey, any chance to merge that in the coming future?

@Longarithm Longarithm added this pull request to the merge queue Jun 28, 2024
@Longarithm
Copy link
Member

Sorry, I forgot that external contributors don't have merge permissions :(
Next time feel free to ping me in Zulip as well.

Merged via the queue into near:master with commit 89fad46 Jun 28, 2024
30 checks passed
@akorchyn
Copy link
Contributor Author

Sure thing. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants