-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Reduced dependencies for various near_* crates #11639
[chore] Reduced dependencies for various near_* crates #11639
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11639 +/- ##
==========================================
- Coverage 71.65% 71.64% -0.02%
==========================================
Files 788 788
Lines 161256 161263 +7
Branches 161256 161263 +7
==========================================
- Hits 115552 115531 -21
- Misses 40674 40699 +25
- Partials 5030 5033 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I left comments mostly for readability, because I was not very familiar with the goal and the approach before.
As you have mentioned, I have created a new issue: #11652 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's amazing, thank you for your contribution!
@Longarithm Hey, any chance to merge that in the coming future? |
Sorry, I forgot that external contributors don't have merge permissions :( |
Sure thing. Thanks ! |
Compilation unit reduction: