Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Use clock in get_protocol_version with upgrade schedule #11640

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

shreyan-gupta
Copy link
Contributor

This change is needed to make setting protocol version in block compatible with test loop that uses fake clock.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.68%. Comparing base (57c9796) to head (7a6e982).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11640      +/-   ##
==========================================
+ Coverage   71.57%   71.68%   +0.10%     
==========================================
  Files         787      787              
  Lines      160728   161063     +335     
  Branches   160728   161063     +335     
==========================================
+ Hits       115039   115452     +413     
+ Misses      40648    40558      -90     
- Partials     5041     5053      +12     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (-0.01%) ⬇️
db-migration 0.23% <0.00%> (-0.01%) ⬇️
genesis-check 1.36% <0.00%> (-0.01%) ⬇️
integration-tests 37.75% <79.31%> (+0.01%) ⬆️
linux 69.05% <100.00%> (+0.05%) ⬆️
linux-nightly 71.17% <100.00%> (+0.10%) ⬆️
macos 52.60% <88.00%> (+1.62%) ⬆️
pytests 1.59% <0.00%> (-0.01%) ⬇️
sanity-checks 1.39% <0.00%> (-0.01%) ⬇️
unittests 66.25% <89.65%> (+0.11%) ⬆️
upgradability 0.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Jun 21, 2024
Merged via the queue into master with commit 71d35d9 Jun 21, 2024
30 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/test/get_protocol_version_with_clock branch June 21, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants