Feat(eth-implicit-accounts): Stabilize protocol change #11765
Conversation
…n the user's signed transaction
…uring the transaction. Rational: this allows relayers to pay for the gas on a user's behalf (by initiating the transaction from their own account) without also needing to pay for other base token transfers involved in the transaction (eg minting wrapped NEAR).
…Near does not guarantee execution order of receipts, so user actions may still be executed out of order even if transactions with sequential nonces arrive in the correct order; the only way to guarantee sequential order of execution is to prevent simultanious in-flight transactions.
…s. Rational: this prevents faulty relayers from griefing users by intentionally submitting transactions incorrectly to prevent their execution. If the nonce is not incremented then an honest relayer can still send the user's original transaction.
…ract call fails. This prevents the user from taking funds from a relayer by intentionally making failed calls. This does not protect the relayer from its own mistakes (e.g. incorrect nonce or invalid transaction); the relayer must still be confident the cross-contract call will execute when choosing to attach NEAR.
|
Will review it today, but it will require a code owner review too. |
runtime/near-wallet-contract/implementation/wallet-contract/src/internal.rs
Outdated
Show resolved
Hide resolved
|
@birchmd could you fix the failing tests? Thanks! |
…eeded because testnet has stateless validation, but mainnet does not and doing the stateless upgrade plus another protocol change does not work in the pytests.
|
RE: test failures The test failures were all in pytest related to stopping a current mainnet node and starting a node from the current branch. I think the reason the tests we failing is because stateless validation is not on mainnet yet and the pytest framework is not setup to do the stateless migration followed by another protocol change. Switching the pytest setup to compare against the current testnet release instead of mainnet made some of the tests pass. But the database migration test still fails. When it tries to restart the node it panics with an error about missing a trie value for congestion info: I do not think this failure is relayed to my change because if I apply ba06adc directly on top of current master I get the same error. So my best guess is that something with congestion info is not currently being properly committed to the trie, but I am not sure. Do you have any suggestions what I could try to fix it? |
@Longarithm could you take a look? |
Alex is OOO, I am looking into it. |
|
@birchmd I would add these 2 commits: 43c5764 and 1029bd1 instead of this one: ba06adc. Just waiting for a resolution of my Zulip question: https://near.zulipchat.com/#narrow/stream/295302-general/topic/Protocol.20version.2070 |
…his is needed because testnet has stateless validation, but mainnet does not and doing the stateless upgrade plus another protocol change does not work in the pytests." This reverts commit ba06adc.
|
Thanks @staffik ! I've added your changes. It's still not clear to me why testing upgrading against testnet doesn't work, but I'm glad your changes to pass the tests! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11765 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 796 796
Lines 162935 162932 -3
Branches 162935 162932 -3
=======================================
+ Hits 116949 116950 +1
+ Misses 40933 40928 -5
- Partials 5053 5054 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR includes changes to the wallet contract based on the audit performed by AuditOne. With the audit complete, we are also ready to stabilize the eth-implicit accounts protocol feature. This is also done as part of this PR.
This is a relatively large PR. To make things easier for nearcore reviewers I recommend looking only at the last commit (which does the protocol stabilization). The various changes to the wallet contract done in the other commits have been reviewed by the auditors that raised the issues each commit is addressing.