fix: Removing flakiness from block_production.py #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test relies on being able to query all the nodes between every two blocks produced. Before 7028068 it was likely but flaky, after it the test fails consistently. It is due to the fact that store validity checks take ~0.35 seconds per `get_status`. Disabling the validity checks for this test. It is generally OK, because practically every other test (e.g. transactions.py) is a superset of this test in terms of coverage, and would catch any storage inconsistency that this test would now miss. Fixes #3143 Test plan: --------- http://nayduck.eastus.cloudapp.azure.com:3000/#/run/97
|
|
bowenwang1996
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test relies on being able to query all the nodes between every two blocks produced.
Before 7028068 it was likely but flaky, after it the test fails consistently.
It is due to the fact that store validity checks take ~0.35 seconds per
get_status.Disabling the validity checks for this test. It is generally OK, because practically
every other test (e.g. transactions.py) is a superset of this test in terms of coverage,
and would catch any storage inconsistency that this test would now miss.
Fixes #3143
Test plan:
http://nayduck.eastus.cloudapp.azure.com:3000/#/run/97