feat(rosettarpc): Data API implementation (revamped) #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #2738 The spec is: https://raw.githubusercontent.com/coinbase/rosetta-specifications/master/api.json (you can view it on https://petstore.swagger.io/) [README](https://github.com/nearprotocol/nearcore/blob/feature/rosetta-api/chain/rosetta-rpc/README.md) This implementation is battle-tested and checked by Coinbase using automated tooling (rosetta-cli)
|
|
Codecov Report
@@ Coverage Diff @@
## master #3275 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 217 217
Lines 43879 43879
=======================================
Hits 38309 38309
Misses 5570 5570 Continue to review full report at Codecov.
|
frol
requested review from
bowenwang1996,
evgenykuzyakov,
MaksymZavershynskyi and
SkidanovAlex
as code owners
evgenykuzyakov
approved these changes
Sep 3, 2020
bowenwang1996
approved these changes
Sep 3, 2020
mhalambek
pushed a commit
that referenced
this pull request
Sep 7, 2020
Fixed the tests by keeping Rosetta RPC server disabled by default (so TCP ports do not collide on concurrent tests execution). Will need to run nightly tests before merging Nayduck is fixed: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/293
chefsale
pushed a commit
that referenced
this pull request
Sep 7, 2020
Fixed the tests by keeping Rosetta RPC server disabled by default (so TCP ports do not collide on concurrent tests execution). Will need to run nightly tests before merging Nayduck is fixed: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the tests by keeping Rosetta RPC server disabled by default (so TCP ports do not collide on concurrent tests execution). Will need to run nightly tests before merging
Nayduck is fixed: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/293