fix(rpc): address slowness in validator rpc #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
khorolets,
MaksymZavershynskyi and
SkidanovAlex
as code owners
bowenwang1996
commented
Feb 15, 2021
matklad
reviewed
Feb 15, 2021
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
frol
reviewed
Feb 18, 2021
frol
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
I approve to unblock this PR. We discussed it offline, and it seems there is a clear path to implement it in a backward-compatible way ([null], ["block-hash"], [block-height-u64] should keep working fine, though the latter two will resolve to the next_epoch_id of the given block, representing the validators stats for the whole epoch, but that is fine)
bowenwang1996
force-pushed
the
fix-validator-rpc
branch
from
8915a8e
to
6c1935e
Compare
SkidanovAlex
approved these changes
Mar 4, 2021
This was referenced Mar 5, 2021
bowenwang1996
added a commit
that referenced
this pull request
Mar 11, 2021
Fix #3614 by disallowing querying the validator rpc endpoint through block hash. Instead, valid queries are either for an epoch or for latest data. Inside epoch manager, validator info for past epochs are stored when we finalize an epoch to ensure that queries will not cause recomputation, which can potentially block the client actor. Test plan --------- * `test_get_validator_info` * `test_get_validator_info_rpc`
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3614 by disallowing querying the validator rpc endpoint through block hash. Instead, valid queries are either for an epoch or for latest data. Inside epoch manager, validator info for past epochs are stored when we finalize an epoch to ensure that queries will not cause recomputation, which can potentially block the client actor.
Test plan
test_get_validator_infotest_get_validator_info_rpc