Add new FramedWrite with buffer limits and stats #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I extracted unrelated changes into #4015 |
pmnoxx
requested review from
bowenwang1996,
evgenykuzyakov,
frol,
khorolets,
mfornet,
MaksymZavershynskyi and
SkidanovAlex
as code owners
matklad
reviewed
Feb 26, 2021
Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
There was a problem hiding this comment.
Please address https://github.com/near/nearcore/pull/4012/files#r585101813
done, all checks also pass |
bowenwang1996
approved these changes
Mar 3, 2021
matklad
reviewed
Mar 3, 2021
bowenwang1996
pushed a commit
that referenced
this pull request
Mar 11, 2021
We should limit the amount of memory each peer is using by limiting size of it's `FrameWrite's` buffer. In addition for each `PeerActor` we will print stats to detect whenever we are not draining it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should limit the amount of memory each peer is using by limiting size of it's
FrameWrite'sbuffer.In addition for each
PeerActorwe will print stats to detect whenever we are not draining it.