fix(runtime): disallow deletion of account with large state #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
bowenwang1996
force-pushed
the
temp-fix-delete-account
branch
from
51ab12c
to
be0504c
Compare
matklad
reviewed
Mar 16, 2021
| "num_block_producer_seats": 50, | ||
| "protocol_version": 43, | ||
| "genesis_time": "1970-01-01T00:00:00.000000000Z", | ||
| "chain_id": "sample", |
There was a problem hiding this comment.
hmm this file is auto generated
Comment on lines
+450
to
+451
| if current_protocol_version | ||
| >= PROTOCOL_FEATURES_TO_VERSION_MAPPING[&ProtocolFeature::DeleteActionRestriction] |
There was a problem hiding this comment.
unrelated to PR, but feels like we can have a nicer API: current_protocol_version.has_feature(ProtocolFeature::DeleteActionRestriction)
There was a problem hiding this comment.
That is a good idea!
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
| @@ -458,7 +457,7 @@ pub(crate) fn action_delete_account( | |||
| // account storage usage should be larger than code size | |||
| let code_len = code.code.len() as u64; | |||
| debug_assert!(account_storage_usage > code_len); | |||
There was a problem hiding this comment.
We don't run debug_assert in prod, right? So it's only for tests
evgenykuzyakov
approved these changes
Mar 16, 2021
bowenwang1996
added a commit
that referenced
this pull request
Mar 17, 2021
For account whose state is large, deleting them is not cheap and this PR prevents accounts with more than 10kb of state (excluding contracts) from being deleted. Contract developers should develop their own logic to delete part of the state if needed. Test plan --------- * `test_delete_account_too_large` * `test_delete_account_with_contract_and_small_state` * `test_delete_account_with_contract_and_large_state` * nayduck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For account whose state is large, deleting them is not cheap and this PR prevents accounts with more than 10kb of state (excluding contracts) from being deleted. Contract developers should develop their own logic to delete part of the state if needed.
Test plan
test_delete_account_too_largetest_delete_account_with_contract_and_small_statetest_delete_account_with_contract_and_large_state