refactor(neard/tests): reduce boilerplate with intuitive structures #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Serially execute every child that's actively running. • Kill the parent of every child that's not yet running so they panic and die of shock. Everybody Dies™ :-)
a delay on start_nodes while a SIGINT is issued\ncould
this way, the main thread (always) awaits completion of its kids the behaviour is a lot more concise, reasonable and effective
matklad
reviewed
Apr 16, 2021
miraclx
force-pushed
the
neard-tests-structured-boilerplate
branch
from
4a57aae
to
56fba0d
Compare
save the extra import
not all tasks within async context are non-blocking issuing a SIGINT while on a blocking task was getting ignored stop actix with exit code 130 in the unix way 🤓
frol
reviewed
Apr 17, 2021
miraclx
force-pushed
the
neard-tests-structured-boilerplate
branch
from
49fbc59
to
8c9ed4a
Compare
frol
approved these changes
Apr 17, 2021
frol
requested review from
bowenwang1996,
evgenykuzyakov,
MaksymZavershynskyi and
SkidanovAlex
as code owners
bowenwang1996
approved these changes
Apr 17, 2021
matklad
added a commit
to matklad/nearcore
that referenced
this pull request
May 13, 2022
I am not sure why we were catching ctrl+c in the first place. This was introduced in near#4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
matklad
added a commit
to matklad/nearcore
that referenced
this pull request
May 13, 2022
I am not sure why we were catching ctrl+c in the first place. This was introduced in near#4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
near-bulldozer bot
pushed a commit
that referenced
this pull request
May 13, 2022
I am not sure why we were catching ctrl+c in the first place. This was introduced in #4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
nikurt
pushed a commit
that referenced
this pull request
May 17, 2022
I am not sure why we were catching ctrl+c in the first place. This was introduced in #4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neard/tests/*are simplified with easy to reason about structures.